gh-146609: Add colour to timeit CLI output#146610
Open
hugovk wants to merge 6 commits intopython:mainfrom
Open
gh-146609: Add colour to timeit CLI output#146610hugovk wants to merge 6 commits intopython:mainfrom
timeit CLI output#146610hugovk wants to merge 6 commits intopython:mainfrom
Conversation
| UserWarning, '', 0) | ||
|
|
||
| print(file=sys.stderr) | ||
| warnings.warn_explicit( |
Member
There was a problem hiding this comment.
I find this very busy currently, maybe it could just be one colour for warnings?
Member
Author
There was a problem hiding this comment.
Can do. All yellow?
I think there is some value highlighting the best/worst somehow. Here's some other toned-down variations.
No bold:
Just best/worst diff colour:
Member
There was a problem hiding this comment.
Just best/worst diff colour:
That seems reasonable to me.
Co-authored-by: Stan Ulbrych <stan@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard and verbose:
With a warning:
./python.exe -m timeit "import time, random; time.sleep(random.random() * 0.5)"As usual, environment variables can control colour output.
timeitCLI output #146609📚 Documentation preview 📚: https://cpython-previews--146610.org.readthedocs.build/